Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #106 +/- ##
=======================================
Coverage 98.55% 98.55%
=======================================
Files 10 10
Lines 1595 1595
Branches 187 187
=======================================
Hits 1572 1572
Misses 12 12
Partials 11 11
Continue to review full report at Codecov.
|
* master: [requires.io] dependency update [requires.io] dependency update Spiff up the tox config a bit more There is no requirements-test.txt file in the source tree. Archor a few paths to the root of the source tree. Minor re-ordering. per CR: rephrase gibberish test docstring per CR: add https:/, enumerate the cases per CR: match __init__ match __init__ doc per CR: explain in much more detail <79 per CR: make the test a little more thorough, improve docstring fix up inconsistencies in parsing & textual representation of 'rooted' and 'uses_netloc' # Conflicts: # .gitignore # MANIFEST.in # tox.ini
|
Restarting builds in hopes that codecov wakes up |
|
@mahmoud if you get some time for a review, this one would be logistically nice, as this is a difficult branch to merge forward repeatedly due to |
mahmoud
left a comment
mahmoud
left a comment
There was a problem hiding this comment.
My main concern with Black is how it affects contributor workflow. Maybe we could use a doc on that?
After we merge this, contributors should run tox -e black-reformat before committing?
Also, don't forget to remove that W504.
| skip_install = {[testenv:black]skip_install} | ||
| deps = {[testenv:black]deps} | ||
| commands = {[testenv:black]commands} | ||
|
|
There was a problem hiding this comment.
So this works because the lint args are absent?
There was a problem hiding this comment.
Yeah, {env:BLACK_LINT_ARGS:} evaluates to "" in the black-reformat environment.
|
Thanks for the And yes, you should run I do use the Tox environment, because I know that'll work even if I don't have |
This PR sets up the
blacklinter.The current branch does not actually run
blackin the defaulttoxconfig, or in CI, so that the reviewer can see what changes are made before we reformat the code base.To run
black, use this command:tox -e black. It will fail, since the code is not yet reformatted to comply withblack's conventions.To test out the reformatting, run
tox -e black-reformat. At this point, runningblack(per above) should succeed.Before merging, we need to (1) reformat the code, (2) add
blackto the defaulttoxenvironment list (it's commented out for now) and (3) add theblacktoxenvironment to the CI config (4) removeW504from theflake8ignore list, as it won't be needed post-reformatting.